feat: decouple Slack one-off audit execution from site enablement #1820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Objective
Allow Slack-triggered audits to run without permanently enabling sites, while maintaining the enabled check for scheduled audits. This addresses the issue where users forget to disable sites after one-off audits, leading to unnecessary scheduled audit runs and increased costs.
📝 Changes
Core Logic Updates
src/common/audit-utils.jsauditContextparameter (default:{}) toisAuditEnabledForSite()functionauditContext.slackContextis present, skip the enabled checksrc/common/runner-audit.jsauditContextfrom SQS messageauditContexttoisAuditEnabledForSite()src/common/step-audit.jsauditContextfrom SQS messageauditContexttoisAuditEnabledForSite()🔗 Related Changes
This PR works in conjunction with:
run-auditcommandaudit enableSlack commandauditContext.slackContextin SQS messages🚀 Deployment Notes
Please ensure your pull request adheres to the following guidelines:
Related Issues
https://jira.corp.adobe.com/browse/SITES-38965
Thanks for contributing!