Skip to content

Conversation

@Sugandhgyl
Copy link
Contributor

@Sugandhgyl Sugandhgyl commented Jan 14, 2026

  • Accessed tagMappings.js with centralized tag mappings utility to ensure all opportunities have standardized tags based on their type from spacecat-shared
  • Updated all opportunity creation handlers to automatically apply hardcoded tags while preserving isElmo/isASO tags and skipping generic opportunities
  • Updated tests to mock tag mappings and expect correct standardized tags, achieving 100% code coverage

Tested with running audits on dev -> https://cq-dev.slack.com/archives/C060T2PPF8V/p1768462780397829

Screenshot 2026-01-15 at 2 35 55 PM

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description - https://jira.corp.adobe.com/browse/SITES-38880
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes
  • If data sources for any opportunity has been updated/added, please update the wiki for same opportunity.

Related Issues

Thanks for contributing!

@github-actions
Copy link

This PR will trigger no release when merged.

@Sugandhgyl Sugandhgyl force-pushed the hardcode-opportunity-tags-1 branch from 3045fb9 to 52d5362 Compare January 15, 2026 06:27
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@habansal habansal mentioned this pull request Jan 15, 2026
3 tasks
@Sugandhgyl Sugandhgyl force-pushed the hardcode-opportunity-tags-1 branch from c1c4bb7 to 4344000 Compare January 15, 2026 11:29
@Sugandhgyl Sugandhgyl requested a review from habansal January 19, 2026 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants