feat: replace Mystique brand presence triggers with DRS (LLMO-1819)#2061
Open
feat: replace Mystique brand presence triggers with DRS (LLMO-1819)#2061
Conversation
dzehnder
force-pushed
the
feat/replace-mystique-with-drs
branch
from
ddb5c39 to
456842a
Compare
|
This PR will trigger a minor release when merged. |
- Remove dead triggerMystiqueCategorization code (DRS config writer already populates categories via LLMO-1819) - Replace triggerGeoBrandPresence/triggerGeoBrandPresenceRefresh calls with DrsClient.triggerBrandDetection() for config-change flows - Remove isAdobe guard (DRS handles all sites uniformly) - Keep old Mystique trigger functions for backward compat (Slack manual) Depends on: adobe/spacecat-shared feat/drs-client-package being published Made-with: Cursor
dzehnder
force-pushed
the
feat/replace-mystique-with-drs
branch
from
456842a to
0cad747
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
triggerMystiqueCategorizationcode (DRS config writer already populates categories via LLMO-1819)triggerGeoBrandPresence/triggerGeoBrandPresenceRefreshcalls inllmo-customer-analysiswithDrsClient.triggerBrandDetection()for config-change flowsisAdobeguard — DRS now handles all sites uniformly (Adobe and external)What changed in llmo-customer-analysis
triggerGeoBrandPresence→ MystiquetriggerBrandDetection→ DRStriggerGeoBrandPresence→ Mystique (non-Adobe only)triggerBrandDetection→ DRS (all sites)triggerGeoBrandPresenceRefresh→ Mystique (non-Adobe only)triggerBrandDetection→ DRS (all sites)Dependencies
@adobe/spacecat-shared-drs-clienttopackage.jsonafter it's publishedDRS_API_URLandDRS_API_KEYenv vars must be added to audit-worker deployment (spacecat-infrastructure)Test plan
import/no-unresolveduntil shared package is publishedllmo-customer-analysishandlerMade with Cursor