Skip to content

Commit

Permalink
fix(textfield): update border and background color (#3505)
Browse files Browse the repository at this point in the history
* feat: migration of tokens to spectrum 2
Expanding the existing themes system to support the new S2 mappings.

---
Co-authored-by: castastrophe <[email protected]>
Co-authored-by: Patrick Fulton <[email protected]>
Co-authored-by: Cory Dransfeldt <[email protected]>
Co-authored-by: Aziz Ramos <[email protected]>
Co-authored-by: Josh Winn <[email protected]>
Co-authored-by: Rise Erpelding <[email protected]>
Co-authored-by: Marissa Huysentruyt <[email protected]>
Co-authored-by: Rajdeep Chandra <[email protected]>
Co-authored-by: TarunAdobe <[email protected]>
Co-authored-by: Dragan Eror<[email protected]>

* chore(textfield): update border and background color

---------

Co-authored-by: [ Cassondra ] <[email protected]>
  • Loading branch information
TarunAdobe and castastrophe committed Jan 23, 2025
1 parent 805e54b commit c684c80
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
5 changes: 5 additions & 0 deletions .changeset/strong-actors-warn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@spectrum-css/textfield": patch
---

Updated the textfield border radius and background-color and added the respective `--mod` property.
2 changes: 1 addition & 1 deletion .github/workflows/vrt.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
exitOnceUploaded: true
onlyChanged: true
traceChanged: true
untraced: ".github/actions/*/package.json generator/package.json"
untraced: ".github/* plugins/stylelint-*/* tools/* .changeset/*"
diagnostics: true
autoAcceptChanges: "main"
# Lets VRT pass without running so as not to waste snapshots
Expand Down
2 changes: 0 additions & 2 deletions components/textfield/dist/metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,6 @@
"--spectrum-component-height-75",
"--spectrum-component-top-to-text-100",
"--spectrum-corner-radius-100",
"--spectrum-disabled-background-color",
"--spectrum-disabled-border-color",
"--spectrum-disabled-content-color",
"--spectrum-field-edge-to-alert-icon-extra-large",
"--spectrum-field-edge-to-alert-icon-large",
Expand Down
4 changes: 1 addition & 3 deletions components/textfield/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@
--spectrum-textfield-text-color-readonly: var(--spectrum-neutral-content-color-default);

/* Disabled Colors */
--spectrum-textfield-background-color-disabled: var(--spectrum-disabled-background-color);
--spectrum-textfield-border-color-disabled: var(--spectrum-disabled-border-color);
--spectrum-textfield-text-color-disabled: var(--spectrum-disabled-content-color);

/* Invalid Colors */
Expand Down Expand Up @@ -504,7 +502,7 @@
.spectrum-Textfield.is-disabled:hover &,
&:disabled {
background-color: var(--mod-textfield-background-color-disabled, var(--spectrum-textfield-background-color-disabled));
border-color: transparent;
border-color: var(--mod-textfield-border-color-disabled, var(--spectrum-textfield-border-color-disabled));
color: var(--highcontrast-textfield-text-color-disabled, var(--mod-textfield-text-color-disabled, var(--spectrum-textfield-text-color-disabled)));

/* Disable the resize functionality when disabled */
Expand Down

0 comments on commit c684c80

Please sign in to comment.