Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototype for testing Adobe Clean VF #3323

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Prototype for testing Adobe Clean VF #3323

wants to merge 3 commits into from
+687 −8

Conversation

5t3ph
Copy link
Collaborator

@5t3ph 5t3ph commented Oct 24, 2024 •
edited
Loading

⚠️ Prototype only - any token changes will be managed appropriately once decisions are made

Prerequisites

Run Creative Cloud via Adobe SSO which will enable the correct font on your local machine.

To Review

Open the deployed Storybook and navigate to the temporary "Testing" nav section and the "Testing Adobe Clean VF" page

https://pr-3323--spectrum-css.netlify.app/preview/?path=/docs/testing-testing-adobe-clean-vf--docs

image

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9ed2e66

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@5t3ph 5t3ph added wip This is a work in progress, don't judge. do not merge A flag for a branch indicating it should not be merged. labels Oct 24, 2024
@5t3ph 5t3ph marked this pull request as ready for review October 24, 2024 19:36
@pfulton pfulton added the skip_vrt Add to a PR to skip running VRT (but still pass the action) label Oct 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://pr-3323--spectrum-css.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

File metrics

Summary

Total size: 4.33 MB*
Total change (Δ): 🔴 ⬆ 24.87 KB (0.56%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Δ
tokens 423.62 KB 🔴 ⬆ 12.37 KB

Details

tokens

Filename Head Compared to base
css/components/bridge/actionbutton.css 12.05 KB -
css/components/bridge/actiongroup.css 0.97 KB -
css/components/bridge/alertbanner.css 0.78 KB -
css/components/bridge/assetcard.css 0.76 KB -
css/components/bridge/button.css 35.45 KB -
css/components/bridge/checkbox.css 1.01 KB -
css/components/bridge/clearbutton.css 1.14 KB -
css/components/bridge/closebutton.css 1.06 KB -
css/components/bridge/combobox.css 1.11 KB -
css/components/bridge/datepicker.css 0.74 KB -
css/components/bridge/index.css 64.71 KB -
css/components/bridge/infieldbutton.css 1.96 KB -
css/components/bridge/picker.css 1.87 KB -
css/components/bridge/pickerbutton.css 1.75 KB -
css/components/bridge/popover.css 0.73 KB -
css/components/bridge/radio.css 1.56 KB -
css/components/bridge/rating.css 1.00 KB -
css/components/bridge/search.css 2.03 KB -
css/components/bridge/slider.css 2.11 KB -
css/components/bridge/stepper.css 3.00 KB -
css/components/bridge/switch.css 1.51 KB -
css/components/bridge/tabs.css 0.72 KB -
css/components/bridge/tag.css 3.51 KB -
css/components/bridge/textfield.css 1.20 KB -
css/components/bridge/toast.css 0.75 KB -
css/components/bridge/tooltip.css 0.77 KB -
css/components/express/actionbutton.css 8.96 KB -
css/components/express/actiongroup.css 0.93 KB -
css/components/express/alertbanner.css 0.77 KB -
css/components/express/assetcard.css 0.73 KB -
css/components/express/button.css 29.37 KB -
css/components/express/checkbox.css 0.95 KB -
css/components/express/clearbutton.css 1.03 KB -
css/components/express/closebutton.css 0.96 KB -
css/components/express/combobox.css 1.01 KB -
css/components/express/datepicker.css 0.73 KB -
css/components/express/index.css 51.93 KB -
css/components/express/infieldbutton.css 1.67 KB -
css/components/express/picker.css 1.51 KB -
css/components/express/pickerbutton.css 1.51 KB -
css/components/express/popover.css 0.69 KB -
css/components/express/radio.css 1.35 KB -
css/components/express/rating.css 1.02 KB -
css/components/express/search.css 1.93 KB -
css/components/express/slider.css 1.78 KB -
css/components/express/stepper.css 2.33 KB -
css/components/express/switch.css 1.29 KB -
css/components/express/tabs.css 0.72 KB -
css/components/express/tag.css 3.28 KB -
css/components/express/textfield.css 1.08 KB -
css/components/express/toast.css 0.75 KB -
css/components/express/tooltip.css 0.76 KB -
css/components/spectrum/actionbutton.css 9.15 KB -
css/components/spectrum/actiongroup.css 0.82 KB -
css/components/spectrum/alertbanner.css 0.77 KB -
css/components/spectrum/assetcard.css 0.72 KB -
css/components/spectrum/button.css 29.43 KB -
css/components/spectrum/checkbox.css 0.94 KB -
css/components/spectrum/clearbutton.css 1.00 KB -
css/components/spectrum/closebutton.css 0.95 KB -
css/components/spectrum/combobox.css 1.02 KB -
css/components/spectrum/datepicker.css 0.72 KB -
css/components/spectrum/index.css 52.13 KB -
css/components/spectrum/infieldbutton.css 1.69 KB -
css/components/spectrum/picker.css 1.60 KB -
css/components/spectrum/pickerbutton.css 1.47 KB -
css/components/spectrum/popover.css 0.72 KB -
css/components/spectrum/radio.css 1.35 KB -
css/components/spectrum/rating.css 1.01 KB -
css/components/spectrum/search.css 1.84 KB -
css/components/spectrum/slider.css 1.75 KB -
css/components/spectrum/stepper.css 2.29 KB -
css/components/spectrum/switch.css 1.28 KB -
css/components/spectrum/tabs.css 0.71 KB -
css/components/spectrum/tag.css 3.30 KB -
css/components/spectrum/textfield.css 1.08 KB -
css/components/spectrum/toast.css 0.75 KB -
css/components/spectrum/tooltip.css 0.76 KB -
css/dark-vars.css 25.19 KB -
css/darkest-vars.css 25.14 KB -
css/express/custom-large-vars.css 1.10 KB -
css/express/custom-medium-vars.css 1.09 KB -
css/express/custom-vars.css 0.67 KB -
css/express/dark-vars.css 1.11 KB -
css/express/darkest-vars.css 1.11 KB -
css/express/global-vars.css 3.02 KB -
css/express/index.css 9.86 KB -
css/express/large-vars.css 3.58 KB -
css/express/light-vars.css 1.15 KB -
css/express/medium-vars.css 3.56 KB -
css/global-vars.css 38.84 KB -
css/large-vars.css 25.07 KB -
css/light-vars.css 25.16 KB -
css/medium-vars.css 25.00 KB -
css/spectrum/custom-large-vars.css 5.26 KB -
css/spectrum/custom-medium-vars.css 5.50 KB -
css/spectrum/custom-vars.css 9.43 KB 🔴 ⬆ 6.24 KB (195.59%)
css/spectrum/dark-vars.css 4.43 KB -
css/spectrum/darkest-vars.css 4.42 KB -
css/spectrum/global-vars.css 12.18 KB 🔴 ⬆ 6.26 KB (105.71%)
css/spectrum/index.css 37.13 KB 🔴 ⬆ 6.13 KB (19.78%)
css/spectrum/large-vars.css 7.56 KB -
css/spectrum/light-vars.css 4.41 KB -
css/spectrum/medium-vars.css 7.80 KB -
index.css 207.85 KB 🔴 ⬆ 6.23 KB (3.09%)
* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@5t3ph 5t3ph marked this pull request as draft October 24, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not merge A flag for a branch indicating it should not be merged. skip_vrt Add to a PR to skip running VRT (but still pass the action) wip This is a work in progress, don't judge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@5t3ph @pfulton