Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progressbar,meter): default width responds to platform #3352

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marissahuysentruyt
Copy link
Collaborator

Description

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@marissahuysentruyt marissahuysentruyt added wip This is a work in progress, don't judge. do not merge A flag for a branch indicating it should not be merged. skip_vrt Add to a PR to skip running VRT (but still pass the action) labels Oct 30, 2024
Copy link

changeset-bot bot commented Oct 30, 2024

⚠️ No Changeset found

Latest commit: a734108

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 30, 2024

🚀 Deployed on https://pr-3352--spectrum-css.netlify.app

@@ -28,6 +28,8 @@
/* --spectrum-global-dimension-static-size-2800 */
--spectrum-progressbar-size-2800: 224px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [stylelint] <spectrum-tools/no-unused-custom-properties> reported by reviewdog 🐶
Unused custom property --spectrum-progressbar-size-2800 defined

Copy link
Contributor

File metrics

Summary

Total size: 4.30 MB*
Total change (Δ): 🔴 ⬆ 0.25 KB (0.01%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Δ
progressbar 10.99 KB 🔴 ⬆ 0.08 KB

Details

progressbar

Filename Head Compared to base
index-base.css 10.99 KB 🔴 ⬆ 0.08 KB (0.73%)
index-vars.css 10.99 KB 🔴 ⬆ 0.08 KB (0.73%)
index.css 10.99 KB 🔴 ⬆ 0.08 KB (0.73%)
* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge A flag for a branch indicating it should not be merged. skip_vrt Add to a PR to skip running VRT (but still pass the action) wip This is a work in progress, don't judge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant