Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype for testing CJK typography #3378

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

5t3ph
Copy link
Collaborator

@5t3ph 5t3ph commented Nov 8, 2024

⚠️ Prototype only to help evaluate any changes needed to improve CJK typography

To Review

Deploy preview

Within the storybook, change the language through the top toolbar to Japanese (second option) to ensure the font and related tokens are switched based on :lang(ja)

image

Visit the new temp page for "Testing CJK Typography"

image

@5t3ph 5t3ph added wip This is a work in progress, don't judge. do not merge A flag for a branch indicating it should not be merged. skip_vrt Add to a PR to skip running VRT (but still pass the action) labels Nov 8, 2024
Copy link

changeset-bot bot commented Nov 8, 2024

⚠️ No Changeset found

Latest commit: ae3060d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 8, 2024

🚀 Deployed on https://pr-3378--spectrum-css.netlify.app

@5t3ph 5t3ph marked this pull request as draft November 8, 2024 17:58
Copy link
Contributor

github-actions bot commented Nov 8, 2024

File metrics

Summary

Total size: 4.26 MB*
Total change (Δ): 🔴 ⬆ 5.02 KB (0.12%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Δ
search 14.92 KB 🔴 ⬆ 0.27 KB
typography 41.02 KB 🔴 ⬆ 0.90 KB
tokens 412.06 KB 🔴 ⬆ 0.82 KB

Details

search

Filename Head Compared to base
index-base.css 12.38 KB 🔴 ⬆ 0.27 KB (2.14%)
index-theme.css 3.16 KB -
index-vars.css 14.92 KB 🔴 ⬆ 0.27 KB (1.76%)
index.css 14.92 KB 🔴 ⬆ 0.27 KB (1.76%)
themes/express.css 1.93 KB -
themes/spectrum.css 1.84 KB -

typography

Filename Head Compared to base
index-base.css 41.02 KB 🔴 ⬆ 0.90 KB (2.19%)
index-vars.css 41.02 KB 🔴 ⬆ 0.90 KB (2.19%)
index.css 41.02 KB 🔴 ⬆ 0.90 KB (2.19%)

tokens

Filename Head Compared to base
css/components/bridge/actionbutton.css 12.05 KB -
css/components/bridge/actiongroup.css 0.97 KB -
css/components/bridge/alertbanner.css 0.78 KB -
css/components/bridge/assetcard.css 0.76 KB -
css/components/bridge/button.css 35.45 KB -
css/components/bridge/checkbox.css 1.01 KB -
css/components/bridge/clearbutton.css 1.14 KB -
css/components/bridge/closebutton.css 1.06 KB -
css/components/bridge/combobox.css 1.11 KB -
css/components/bridge/datepicker.css 0.74 KB -
css/components/bridge/index.css 64.71 KB -
css/components/bridge/infieldbutton.css 1.96 KB -
css/components/bridge/picker.css 1.87 KB -
css/components/bridge/pickerbutton.css 1.75 KB -
css/components/bridge/popover.css 0.73 KB -
css/components/bridge/radio.css 1.56 KB -
css/components/bridge/rating.css 1.00 KB -
css/components/bridge/search.css 2.03 KB -
css/components/bridge/slider.css 2.11 KB -
css/components/bridge/stepper.css 3.00 KB -
css/components/bridge/switch.css 1.51 KB -
css/components/bridge/tabs.css 0.72 KB -
css/components/bridge/tag.css 3.51 KB -
css/components/bridge/textfield.css 1.20 KB -
css/components/bridge/toast.css 0.75 KB -
css/components/bridge/tooltip.css 0.77 KB -
css/components/express/actionbutton.css 8.96 KB -
css/components/express/actiongroup.css 0.93 KB -
css/components/express/alertbanner.css 0.77 KB -
css/components/express/assetcard.css 0.73 KB -
css/components/express/button.css 29.37 KB -
css/components/express/checkbox.css 0.95 KB -
css/components/express/clearbutton.css 1.03 KB -
css/components/express/closebutton.css 0.96 KB -
css/components/express/combobox.css 1.01 KB -
css/components/express/datepicker.css 0.73 KB -
css/components/express/index.css 51.93 KB -
css/components/express/infieldbutton.css 1.67 KB -
css/components/express/picker.css 1.51 KB -
css/components/express/pickerbutton.css 1.51 KB -
css/components/express/popover.css 0.69 KB -
css/components/express/radio.css 1.35 KB -
css/components/express/rating.css 1.02 KB -
css/components/express/search.css 1.93 KB -
css/components/express/slider.css 1.78 KB -
css/components/express/stepper.css 2.33 KB -
css/components/express/switch.css 1.29 KB -
css/components/express/tabs.css 0.72 KB -
css/components/express/tag.css 3.28 KB -
css/components/express/textfield.css 1.08 KB -
css/components/express/toast.css 0.75 KB -
css/components/express/tooltip.css 0.76 KB -
css/components/spectrum/actionbutton.css 9.15 KB -
css/components/spectrum/actiongroup.css 0.82 KB -
css/components/spectrum/alertbanner.css 0.77 KB -
css/components/spectrum/assetcard.css 0.72 KB -
css/components/spectrum/button.css 29.43 KB -
css/components/spectrum/checkbox.css 0.94 KB -
css/components/spectrum/clearbutton.css 1.00 KB -
css/components/spectrum/closebutton.css 0.95 KB -
css/components/spectrum/combobox.css 1.02 KB -
css/components/spectrum/datepicker.css 0.72 KB -
css/components/spectrum/index.css 52.13 KB -
css/components/spectrum/infieldbutton.css 1.69 KB -
css/components/spectrum/picker.css 1.60 KB -
css/components/spectrum/pickerbutton.css 1.47 KB -
css/components/spectrum/popover.css 0.72 KB -
css/components/spectrum/radio.css 1.35 KB -
css/components/spectrum/rating.css 1.01 KB -
css/components/spectrum/search.css 1.84 KB -
css/components/spectrum/slider.css 1.75 KB -
css/components/spectrum/stepper.css 2.29 KB -
css/components/spectrum/switch.css 1.28 KB -
css/components/spectrum/tabs.css 0.71 KB -
css/components/spectrum/tag.css 3.30 KB -
css/components/spectrum/textfield.css 1.08 KB -
css/components/spectrum/toast.css 0.75 KB -
css/components/spectrum/tooltip.css 0.76 KB -
css/dark-vars.css 25.19 KB -
css/darkest-vars.css 25.14 KB -
css/express/custom-large-vars.css 1.10 KB -
css/express/custom-medium-vars.css 1.08 KB -
css/express/custom-vars.css 0.67 KB -
css/express/dark-vars.css 1.10 KB -
css/express/darkest-vars.css 1.11 KB -
css/express/global-vars.css 3.02 KB -
css/express/index.css 9.86 KB -
css/express/large-vars.css 3.58 KB -
css/express/light-vars.css 1.14 KB -
css/express/medium-vars.css 3.56 KB -
css/global-vars.css 39.58 KB 🔴 ⬆ 0.76 KB (1.91%)
css/large-vars.css 25.10 KB 🔴 ⬆ 0.03 KB (0.12%)
css/light-vars.css 25.16 KB -
css/medium-vars.css 25.03 KB 🔴 ⬆ 0.03 KB (0.13%)
css/spectrum/custom-large-vars.css 5.17 KB -
css/spectrum/custom-medium-vars.css 5.42 KB -
css/spectrum/custom-vars.css 3.17 KB -
css/spectrum/dark-vars.css 4.38 KB -
css/spectrum/darkest-vars.css 4.38 KB -
css/spectrum/global-vars.css 5.90 KB -
css/spectrum/index.css 31.00 KB -
css/spectrum/large-vars.css 7.48 KB -
css/spectrum/light-vars.css 4.36 KB -
css/spectrum/medium-vars.css 7.71 KB -
index.css 202.42 KB 🔴 ⬆ 0.82 KB (0.40%)
* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge A flag for a branch indicating it should not be merged. skip_vrt Add to a PR to skip running VRT (but still pass the action) wip This is a work in progress, don't judge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant