-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: migrate from nx to workspaces #3455
Draft
castastrophe
wants to merge
22
commits into
s2-foundations-redux
Choose a base branch
from
build-migrate-off-nx
base: s2-foundations-redux
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+44,791
−25,808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4cc2196 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
castastrophe
force-pushed
the
build-migrate-off-nx
branch
9 times, most recently
from
December 19, 2024 20:39
8ec8f1c
to
cf8fda9
Compare
castastrophe
force-pushed
the
s2-foundations-redux
branch
2 times, most recently
from
December 29, 2024 18:29
c56b926
to
79eb129
Compare
castastrophe
force-pushed
the
s2-foundations-redux
branch
from
January 2, 2025 21:44
d8a3f18
to
3bbc0e5
Compare
castastrophe
force-pushed
the
build-migrate-off-nx
branch
3 times, most recently
from
January 3, 2025 03:19
edd1094
to
853fc83
Compare
castastrophe
force-pushed
the
s2-foundations-redux
branch
2 times, most recently
from
January 6, 2025 18:47
9c3a625
to
d6c8c69
Compare
Expanding the existing themes system to support the new S2 mappings. --- Co-authored-by: castastrophe <[email protected]> Co-authored-by: Patrick Fulton <[email protected]> Co-authored-by: Cory Dransfeldt <[email protected]> Co-authored-by: Aziz Ramos <[email protected]> Co-authored-by: Josh Winn <[email protected]> Co-authored-by: Rise Erpelding <[email protected]> Co-authored-by: Marissa Huysentruyt <[email protected]> Co-authored-by: Rajdeep Chandra <[email protected]> Co-authored-by: TarunAdobe <[email protected]> Co-authored-by: Dragan Eror<[email protected]>
* feat: s2 foundations non-gray-800 colors update * add changeset
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
--- Co-authored-by: TarunAdobe <[email protected]>
--- Co-authored-by: TarunAdobe <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* docs(contextualhelp): remove MDX file - adds some additional documentation regarding stories/variants - migrates documentation in MDX to stories.js instead * docs(fieldgroup): remove MDX file - creates additional templates to showcase variants in a single story on the docs page - additional documentation to give context to stories - corrects sentence-casing in story names - removes duplicate control for label text - migrates documentation in MDX to stories.js instead * chore(fieldgroup,contextualhelp): cleans up test files - fieldgroup: we don't really need to change the label text or help text between test cases, so some of the test-specific changes were removed - contextualhelp: add help icon test case * docs(datepicker): remove MDX file - adds missing date picker docs - migrates documentation in MDX to stories.js instead - creates OpenClosedTemplate to display both states in a single story on the docs page - adds Range variant to the sidebar since that control isn't in the table
castastrophe
force-pushed
the
s2-foundations-redux
branch
21 times, most recently
from
January 14, 2025 14:34
b77c8b2
to
d020047
Compare
castastrophe
force-pushed
the
s2-foundations-redux
branch
7 times, most recently
from
January 17, 2025 03:36
3114d29
to
246fa4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Working to migrate off of NX as a build workflow tool in favor of the built-in system available in Yarn. Why? Fewer additional dependencies and more straight-forward tooling makes onboarding contributors easier. While NX does offer better caching services, yarn has a better user-experience for parallelizing on the command line.
This PR also defines certain constraints for our component packages. Constraints are a feature of Yarn that allows us to define properties for the package.json to keep them aligned and consistent.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list