Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: migrate from nx to workspaces #3455

Draft
wants to merge 22 commits into
base: s2-foundations-redux
Choose a base branch
from

Conversation

castastrophe
Copy link
Collaborator

Description

Working to migrate off of NX as a build workflow tool in favor of the built-in system available in Yarn. Why? Fewer additional dependencies and more straight-forward tooling makes onboarding contributors easier. While NX does offer better caching services, yarn has a better user-experience for parallelizing on the command line.

This PR also defines certain constraints for our component packages. Constraints are a feature of Yarn that allows us to define properties for the package.json to keep them aligned and consistent.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: 4cc2196

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@spectrum-tools/theme-alignment Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@castastrophe castastrophe force-pushed the build-migrate-off-nx branch 9 times, most recently from 8ec8f1c to cf8fda9 Compare December 19, 2024 20:39
@castastrophe castastrophe force-pushed the s2-foundations-redux branch 2 times, most recently from c56b926 to 79eb129 Compare December 29, 2024 18:29
@castastrophe castastrophe force-pushed the build-migrate-off-nx branch 3 times, most recently from edd1094 to 853fc83 Compare January 3, 2025 03:19
@castastrophe castastrophe force-pushed the s2-foundations-redux branch 2 times, most recently from 9c3a625 to d6c8c69 Compare January 6, 2025 18:47
castastrophe and others added 12 commits January 6, 2025 16:52
Expanding the existing themes system to support the new S2 mappings.

---
Co-authored-by: castastrophe <[email protected]>
Co-authored-by: Patrick Fulton <[email protected]>
Co-authored-by: Cory Dransfeldt <[email protected]>
Co-authored-by: Aziz Ramos <[email protected]>
Co-authored-by: Josh Winn <[email protected]>
Co-authored-by: Rise Erpelding <[email protected]>
Co-authored-by: Marissa Huysentruyt <[email protected]>
Co-authored-by: Rajdeep Chandra <[email protected]>
Co-authored-by: TarunAdobe <[email protected]>
Co-authored-by: Dragan Eror<[email protected]>
* feat: s2 foundations non-gray-800 colors update

* add changeset
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* docs(contextualhelp): remove MDX file

- adds some additional documentation regarding stories/variants
- migrates documentation in MDX to stories.js instead

* docs(fieldgroup): remove MDX file

- creates additional templates to showcase variants in a single story on
the docs page
- additional documentation to give context to stories
- corrects sentence-casing in story names
- removes duplicate control for label text
- migrates documentation in MDX to stories.js instead

* chore(fieldgroup,contextualhelp): cleans up test files

- fieldgroup: we don't really need to change the label text or help text
between test cases, so some of the test-specific changes were removed
- contextualhelp: add help icon test case

* docs(datepicker): remove MDX file

- adds missing date picker docs
- migrates documentation in MDX to stories.js instead
- creates OpenClosedTemplate to display both states in a single story on
the docs page
- adds Range variant to the sidebar since that control isn't in the table
@castastrophe castastrophe force-pushed the s2-foundations-redux branch 21 times, most recently from b77c8b2 to d020047 Compare January 14, 2025 14:34
@castastrophe castastrophe added s1 S2 Spectrum 2 labels Jan 15, 2025
@castastrophe castastrophe force-pushed the s2-foundations-redux branch 7 times, most recently from 3114d29 to 246fa4d Compare January 17, 2025 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s1 S2 Spectrum 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants