-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(generator): migrate to tools folder #3501
Conversation
|
🚀 Deployed on https://pr-3501--spectrum-css.netlify.app |
File metricsSummaryTotal size: 3.89 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
Not sure if you want to address now or future but when I ran the generator it had a few hiccups:
|
These are great points! I'll focus this PR on just moving the package but I opened a backlog issue to return & address the generation separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran through the validation steps and works as expected. ✨
fdd5ead
to
21310de
Compare
Description
As the generator is a utility or "tool" for the project, this package would be better served under the tools directory. This PR moves the generator package into the tools folder and updates the necessary scripts and pathing to support the change.
Bonus: the generator works again!
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
yarn new
: choose component and answer the prompts - expect it to make a new component! (@cdransf)To-do list