-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: postcss plugin updates and fixes #3502
Conversation
🦋 Changeset detectedLatest commit: f04583d The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Deployed on https://pr-3502--spectrum-css.netlify.app |
File metricsSummaryTotal size: 3.32 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailsactionbutton
actiongroup
alertbanner
assetcard
avatar
button
card
checkbox
clearbutton
closebutton
colorhandle
colorwheel
combobox
datepicker
dial
floatingactionbutton
infieldbutton
link
logicbutton
modal
opacitycheckerboard
picker
pickerbutton
popover
progresscircle
radio
rating
search
sidenav
slider
stepper
swatch
switch
tabs
tag
textfield
toast
tooltip
typography
tokens
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
e975bdb
to
c8827bc
Compare
8e20677
to
8260c1c
Compare
ddb07d4
to
44f8b04
Compare
cc057e6
to
80075ba
Compare
@pfulton Note that I didn't add a changeset entry to tokens, that's because it resulted only in whitespace updates so it didn't require any versioning changes. |
80075ba
to
bd17f34
Compare
bd17f34
to
f04583d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran through all of the validation steps and didn't encounter any issues! ✨
Description
Remove empty theming assets from components that don't require theming.
Update how the
--system
custom properties are generated to streamline and clean-up the naming process to make them more readable. Additional updates are documented in full detail in the changelog.How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
--system
property names. i.e.--system-spectrum-actionbutton-staticwhite-selected-mod-actionbutton-content-color-hover
becomes--system-action-button-static-white-selected-content-color-hover
instead (note that the duplicate component name is removed, no mod prefix is included, and component names include the dash present in the class name's capitalization). (@cdransf)Validate no issues with the following commands:
yarn build
(@cdransf)yarn start
(@cdransf)Regression testing
Validate:
To-do list