Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(badge): remove duplicate import causing error #3510

Closed
wants to merge 0 commits into from

Conversation

jawinn
Copy link
Collaborator

@jawinn jawinn commented Jan 17, 2025

Description

Removes a duplicate import from the Badge component stories file that was causing Storybook to error on yarn start.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • Storybook runs again on yarn start. The Badge related error is gone.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Jan 17, 2025

⚠️ No Changeset found

Latest commit: 0c431fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jawinn jawinn added ready-for-review S2 Spectrum 2 size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. labels Jan 17, 2025
Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

github-actions bot commented Jan 17, 2025

File metrics

Summary

Total size: 2.23 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@marissahuysentruyt marissahuysentruyt dismissed their stale review January 17, 2025 17:36

approved too quickly.

@jawinn jawinn marked this pull request as draft January 17, 2025 17:43
@jawinn
Copy link
Collaborator Author

jawinn commented Jan 17, 2025

Switching this back to draft for the time being. Though it fixes the error in question, there are more errors going on in the spectrum-two branch post rebase that need looking at.

@rise-erpelding rise-erpelding force-pushed the jawinn/fix-s2-badge-import branch from aca7ecc to d6275c0 Compare January 21, 2025 16:17
@rise-erpelding rise-erpelding marked this pull request as ready for review January 21, 2025 16:18
@castastrophe castastrophe force-pushed the jawinn/fix-s2-badge-import branch from d6275c0 to 0c431fc Compare January 22, 2025 01:46
@castastrophe castastrophe deleted the jawinn/fix-s2-badge-import branch January 22, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review S2 Spectrum 2 size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants