feat: update postcss tooling #3527
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e391661 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
File metricsSummaryTotal size: 2.24 MB*
File change detailsaccordion
actionbutton
alertbanner
asset
assetcard
assetlist
button
calendar
card
clearbutton
coachindicator
colorarea
colorhandle
colorloupe
colorwheel
combobox
dial
dialog
divider
dropzone
fieldlabel
floatingactionbutton
form
icon
illustratedmessage
logicbutton
menu
miller
modal
opacitycheckerboard
pagination
picker
popover
progresscircle
slider
statuslight
steplist
stepper
swatch
table
tooltip
tray
treeview
typography
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
castastrophe
force-pushed
the
feat-update-postcss-tooling
branch
4 times, most recently
from
ee65449 to
cf1a9f3
Compare
castastrophe
force-pushed
the
feat-update-postcss-tooling
branch
from
cf1a9f3 to
92c03c9
Compare
castastrophe
force-pushed
the
feat-update-postcss-tooling
branch
5 times, most recently
from
bca4cd9 to
014150d
Compare
castastrophe
force-pushed
the
main
branch
2 times, most recently
from
0d5bdfb to
8637d39
Compare
castastrophe
force-pushed
the
feat-update-postcss-tooling
branch
2 times, most recently
from
0b755b1 to
ef803f7
Compare
|
🚀 Deployed on https://pr-3527--spectrum-css.netlify.app |
castastrophe
force-pushed
the
feat-update-postcss-tooling
branch
2 times, most recently
from
2a75e72 to
3f44956
Compare
castastrophe
force-pushed
the
main
branch
10 times, most recently
from
c68f4e3 to
d2272ea
Compare
castastrophe
force-pushed
the
feat-update-postcss-tooling
branch
from
3f44956 to
3636391
Compare
castastrophe
force-pushed
the
feat-update-postcss-tooling
branch
from
d254b53 to
cdee561
Compare
castastrophe
added
dependencies
castastrophe
force-pushed
the
feat-update-postcss-tooling
branch
from
cdee561 to
e391661
Compare
castastrophe
commented
Mar 12, 2025
| @@ -104,7 +104,17 @@ export default { | |||
| devSourcemap: configType === "DEVELOPMENT", | |||
| }, | |||
| resolve: { | |||
| alias: components.map(component => ({ find: `@spectrum-css/${component}`, replacement: path.resolve(__dirname, `../components/${component}`) })), | |||
| alias: [ | |||
| ...components.map(component => ({ find: `@spectrum-css/${component}`, replacement: path.resolve(__dirname, `../components/${component}`) })), | |||
There was a problem hiding this comment.
This gently expands our local alias'ing should we need it in future for more direct imports.
| @@ -42,7 +42,7 @@ | |||
| "@adobe/spectrum-css-workflow-icons": "^1.5.4", | |||
| "@spectrum-css/bundle": "1.0.0", | |||
| "@spectrum-css/tokens": "16.0.1", | |||
| "@spectrum-css/tokens-legacy": "npm:@spectrum-css/tokens@^15.2.0", | |||
| "@spectrum-css/tokens-legacy": "npm:@spectrum-css/tokens@^15.0.0", | |||
There was a problem hiding this comment.
There seems to be an issue with the 15.2.0 tokens.json file so I pulled back to 15.0.0 where no issues exist.
| @@ -70,7 +70,7 @@ | |||
| "lodash-es": "^4.17.21", | |||
| "npm-registry-fetch": "^18.0.2", | |||
| "postcss": "^8.5.3", | |||
| "prettier": "^3.4.2", | |||
| "prettier": "^3.5.3", | |||
There was a problem hiding this comment.
Minor update to prettier to get the latest functionality.
| @@ -70,16 +70,17 @@ | |||
| "@changesets/cli": "^2.27.11", | |||
| "@commitlint/cli": "^19.6.1", | |||
| "@commitlint/config-conventional": "^19.6.0", | |||
| "@csstools/postcss-bundler": "^2.0.6", | |||
There was a problem hiding this comment.
Added the postcss-bundler for the Storybook styles being processed so we have a more optimized and usable product for even our internal CSS.
Comment on lines
+108
to
+109
| "postcss-licensing": "^3.0.0", | ||
| "postcss-load-config": "^6.0.1", |
There was a problem hiding this comment.
Validated postcss-licensing breaking change update because no licensing results have changed. 🥳
Validated postcss-load-config breaking change because the config loading in the scripts are not failing or returning different results.
| "postcss-modules": "^6.0.1", | ||
| "postcss-preset-env": "^9.5.13", | ||
| "postcss-preset-env": "^10.1.5", |
There was a problem hiding this comment.
This is the primary update in the PR as results in the change to the focus-within selectors.
| "dir-pseudo-class": { preserve: true }, | ||
| "nesting-rules": { noIsPseudoSelector: true }, |
There was a problem hiding this comment.
A lot of these settings can be removed as the defaults in the latest version align with our configurations.
| resolveNestedSelectors: true | ||
| } | ||
| ], | ||
| "selector-class-pattern": null, |
There was a problem hiding this comment.
We don't need to report errors for Storybook selectors.
castastrophe
force-pushed
the
feat-update-postcss-tooling
branch
from
e391661 to
d7f211f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By updating the postcss-preset-env to the latest breaking change version, output for this component no longer injects the
.js-focus-withinand '[focus-within]` selectors for the focus-within polyfill.As this fallback feature is not currently used in SWC, risk to the end user for this removal is low. Changes appear in: clearbutton, assetlist, slider, dial, menu.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
yarn build: expect to see no new error messages or new warnings. Validating no changes to the build output.yarn storybook: validate that the storybook opens and has no new errors introduced.Regression testing
Validate:
To-do list