-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tokens): export json, remove duplicate file generation #3529
Conversation
🦋 Changeset detectedLatest commit: cb797cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0f1a610
to
c02f58d
Compare
🚀 Deployed on https://pr-3529--spectrum-css.netlify.app |
c02f58d
to
ff379d3
Compare
File metricsSummaryTotal size: 3.25 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailstokens
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
ff379d3
to
5d902f9
Compare
b508873
to
85e4739
Compare
85e4739
to
cb797cb
Compare
Description
Add JSON to token package exports.
Remove CSS files from commit history (but continue to build and ship them in the releases).
Stop physically copying the
dist/css/index.css
todist/index.css
and instead, mapdist/index.css
in the package exports to the samedist/css/index.css
file.How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Expect to see the bundled
index.css
files for the tokensdist
output not reflected in diffs for a pull request. Expect the files to continue to be generated.@adobe/spectrum-tokens
package version being used by tokens.yarn builder tokens --skip-nx-cache
. Do not commit the changes.index.css
asset listed in the files staged or unstaged for commit.*-vars.css
and thetokens.json
resource.yarn compare tokens
.To-do list