-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(slider): corrects contrast bug caused by template default arg #3614
Conversation
|
File metricsSummaryTotal size: 2.25 MB* 🎉 No changes detected in any packages * Size is the sum of all main files for packages in the library.* An ASCII character in UTF-8 is 8 bits or 1 byte. |
🚀 Deployed on https://pr-3614--spectrum-css.netlify.app |
f56782b
to
e7e160b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for digging into the gray values- glad we got them corrected!
Looking at prod, is this PR supposed to address main
? I think I see the same issue, so if we fix it on main
, could we just cherry pick over to spectrum-two
?

adbf4c0
to
1de25b8
Compare
25b7240
to
b05f885
Compare
0e2b62a
to
54562e4
Compare
Absolutely! I lifted everything over to main and squashed it down so we can cherry-pick in a follow up PR. ✨ |
54562e4
to
6200ea4
Compare
6200ea4
to
f5fb64c
Compare
c68f4e3
to
d2272ea
Compare
f5fb64c
to
ca1eb32
Compare
Description
Corrects the contrast issue observed between the fill element and slider track that caused the fill element to be difficult to see.
Validation steps
Screenshots
To-do list