fix(infield-button): updated border color for disabled state #3615
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e67cfc7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
File metricsSummaryTotal size: 2.25 MB*
File change detailsaccordion
actionbutton
alertbanner
asset
assetcard
assetlist
button
calendar
card
checkbox
clearbutton
coachindicator
colorarea
colorhandle
colorloupe
colorwheel
combobox
dial
dialog
divider
dropzone
fieldlabel
floatingactionbutton
form
icon
illustratedmessage
infieldbutton
logicbutton
menu
miller
modal
opacitycheckerboard
pagination
picker
pickerbutton
popover
progresscircle
slider
statuslight
steplist
stepper
swatch
table
tooltip
tray
treeview
typography
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
|
🚀 Deployed on https://pr-3615--spectrum-css.netlify.app |
rise-erpelding
previously requested changes
Mar 12, 2025
.changeset/popular-trains-sniff.md
Outdated
| "@spectrum-css/infieldbutton": patch | ||
| --- | ||
|
|
||
| updated infield button disabled border color for spectrum-two theme |
There was a problem hiding this comment.
We've been trying to be more conscious of how our documentation in changelogs looks, could we update this to something a little more formatted and descriptive of the changes such as:
Suggested change
| updated infield button disabled border color for spectrum-two theme | |
| Updated infield button disabled border color to use `--spectrum-gray-300` for spectrum-two theme and `--spectrum-gray-200` for other themes. |
There was a problem hiding this comment.
@rise-erpelding I pushed up the change for this!
castastrophe
force-pushed
the
main
branch
10 times, most recently
from
c68f4e3 to
d2272ea
Compare
castastrophe
force-pushed
the
rajdeep/infield-button-fast-follow
branch
from
9ed6e2a to
e67cfc7
Compare
rise-erpelding
dismissed
their stale review
Dismissing review so as not to block approval/merging from others while I'm out!
castastrophe
added
the
fast-follows
| @@ -27,5 +27,9 @@ | |||
| --spectrum-infield-button-background-color-hover: var(--spectrum-gray-200); | |||
| --spectrum-infield-button-background-color-down: var(--spectrum-gray-200); | |||
| --spectrum-infield-button-background-color-key-focus: var(--spectrum-gray-200); | |||
|
|
|||
| &:disabled { | |||
| --spectrum-infield-button-border-color: var(--spectrum-gray-300); | |||
There was a problem hiding this comment.
This probably could be set to disabled-border-color if we wanted. I think that's also gray-300.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the below value of disabled border of infield-button
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list