fix(tabs): added missing direct dependency of action-button in TabsOverflow component #5429
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajdeepc
changed the title
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsChrometabs permalinkbasic-test
Firefoxtabs permalinkbasic-test
|
castastrophe
approved these changes
May 5, 2025
🦋 Changeset detectedLatest commit: dda2702 The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
@spectrum-web-components/action-buttondependency to thesp-tabscomponent to maintain consistency with other components in the library. TabsOverflow usessp-action-buttonas its direct dependency.Related issue(s)
Motivation and context
The TabsOverflow component was missing the
@spectrum-web-components/action-buttondependency that other components utilize, which could lead to inconsistencies when implementing shared features. Adding this dependency ensures that the TabsOverflow component follows the same patterns as the rest of the library and can leverage common functionality.How has this been tested?
Verified sp-tabs functionality still works while importing it in a kitchen sink
Verified no side effects from adding shared dependency
Did it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Types of changes
Checklist