Skip to content

chore: release docs update plus auto publish docs site #5436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

caseyisonit
Copy link
Contributor

@caseyisonit caseyisonit commented May 6, 2025

Description

  • Updates the RELEASE_PROCESS.md doc with notes from the last release.
  • Includes some improvements to auto-publish the doc site when the docs commit type merges into main
  • Corrects a label in the auto-update action to watch for ready-for-review.
  • PR template improvements since this is the first one using it.

Motivation and context

  • The release process is now fully documented, including prerequisites, so anyone can get set up and do a release
  • Docs site publishing regularly is a massive low-hanging fruit improvement for our consumers. This will now ensure accessibility doc improvements are shipping quickly and providing value instantly.
  • @castastrophe introduced a super cool action a while ago, and I noticed the label was incorrect. This will now help keep branches up to date with the main that are ready for review.
  • Better PR drafting experience

Related issue(s)

  • NA

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

Manual review test cases

  • Read the RELEASE_PROCESS.md and make sure it reads clearly

@caseyisonit caseyisonit requested a review from a team as a code owner May 6, 2025 02:21
Copy link

changeset-bot bot commented May 6, 2025

⚠️ No Changeset found

Latest commit: 2d77aaf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -1,6 +1,8 @@
<!--- Provide a general summary of your changes in the Title above -->
<!--- PR titles should follow conventional commit and should include commit type as defined in in the PULL_REQUESTS guide -->
<!--- Conventional commit docs can be referenced here: https://www.conventionalcommits.org/en/v1.0.0/#summary -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is linked in PULL_REQUESTS

<!--- Conventional commit docs can be referenced here: https://www.conventionalcommits.org/en/v1.0.0/#summary -->
<!---
- Following conventional commit format, provide a general summary of your changes in the title above.
- Acceptable commit types in order of severity (high to low): feat, fix, docs, style, chore, perf, and test. Commit types are defined in PULL_REQUESTS.md.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Included a list of acceptable types so its easier to know which ones we use

<!---
- Following conventional commit format, provide a general summary of your changes in the title above.
- Acceptable commit types in order of severity (high to low): feat, fix, docs, style, chore, perf, and test. Commit types are defined in PULL_REQUESTS.md.
- For example,`type(component): general summary`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example structure for clarity

- Include links and manual steps for how the reviewer should go through to verify your changes.
- Be sure to include all areas of the codebase that might be affected. Any components that use these changes for a dependency should be cross-checked for regressions.
- For example, changes to Menu Item will affect Picker, Menu, and Action Menu.
-->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reformatted for readability in PR drafting and consistency

Copy link

github-actions bot commented May 6, 2025

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@@ -23,4 +23,4 @@ jobs:
include_drafts: false
limit: 50
exclude_labels: blocked,wip
include_labels: in-review,ready-for-merge
include_labels: ready-for-review,ready-for-merge
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the label we use in swc repo, @castastrophe let me know if I'm misunderstanding the word label here :)

# Run the job if manually triggered or if the commit message includes '#publish' & the check suite has passed
if: github.event_name == 'workflow_dispatch' || contains(github.event.head_commit.message, '#publish')
# Run the job if manually triggered or if the commit message includes '#publish' & the check suite has passed or if the commit message includes 'docs' and the check suite has passed
if: github.event_name == 'workflow_dispatch' || contains(github.event.head_commit.message, '#publish') || contains(github.event.head_commit.message, 'docs')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will publish the docs site if the docs commit type is included in the merge message

Copy link

github-actions bot commented May 6, 2025

Tachometer results

Currently, no packages are changed by this PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant