-
Notifications
You must be signed in to change notification settings - Fork 239
chore(base): remove dir management from SpectrumElement and sp-theme
#5936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
58c9ada to
55fcc7c
Compare
dir management from SpectrumMixin
dir management from SpectrumMixindir management from SpectrumElemen
dir management from SpectrumElemendir management from SpectrumElement
| flex-direction: column; | ||
| } | ||
|
|
||
| @media screen and (max-width: 960px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [stylelint] <media-feature-range-notation> reported by reviewdog 🐶
Expected "context" media feature range notation
dir management from SpectrumElementdir management from SpectrumElement and sp-theme
|
Solid modernization effort, we just cleaned up 4+ years of workaround code. |
Description
Motivation and context
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Descriptive Test Statement
Descriptive Test Statement
Device review