Skip to content

Add 600-weight Trebuchet fallback and fix Arabic fallback bold metrics #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nateyolles wants to merge 1 commit into
base: stage
Choose a base branch
from
Draft

Add 600-weight Trebuchet fallback and fix Arabic fallback bold metrics #720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions express/code/styles/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,21 @@
src: local('Trebuchet MS'), local('TrebuchetMS'), local('Arial'), local('Helvetica');
}

/* 600-weight fallback: browsers resolve local Trebuchet MS/Arial to their bold face at this
weight, so size-adjust is recalculated against that wider glyph set to match Adobe Clean
600's own metrics; ascent/descent stay the same since Adobe Clean's vertical metrics don't
change across weights */
@font-face {
font-family: 'adobe-clean-fallback';
font-display: swap;
size-adjust: 89.1%;
font-weight: 600;
ascent-override: 95%;
descent-override: 25%;
line-gap-override: 0%;
src: local('Trebuchet MS Bold'), local('TrebuchetMS Bold'), local('Arial Bold'), local('Helvetica Bold');
}

/* Arabic fallback chain: Trebuchet MS has no Arabic glyph coverage, so use Arial first */
@font-face {
font-family: 'adobe-clean-fallback-ar';
Expand All @@ -35,7 +50,8 @@
ascent-override: 88.67%;
descent-override: 51.75%;
line-gap-override: 0%;
src: local('Arial'), local('Helvetica');
unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF;
src: local('Arial Bold'), local('Helvetica Bold');
}

@font-face {
Expand All @@ -46,7 +62,8 @@
ascent-override: 88.67%;
descent-override: 51.75%;
line-gap-override: 0%;
src: local('Arial'), local('Helvetica');
unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF;
src: local('Arial Bold'), local('Helvetica Bold');
}

:root {
Expand Down Expand Up @@ -514,7 +531,7 @@ body[data-device="mobile"] {
}

:root:lang(ar) {
--body-font-family: adobe-clean-arabic, 'Adobe Clean', adobe-clean, adobe-arabic, myriad-arabic, 'adobe-clean-fallback-ar', 'Arial', sans-serif
--body-font-family: adobe-clean-arabic, 'Adobe Clean', adobe-clean, adobe-arabic, myriad-arabic, 'adobe-clean-fallback-ar', 'adobe-clean-fallback', 'Arial', sans-serif
}

:is(p):lang(ja) {
Expand Down
Loading