[MWPW-205908] Add empty states and fix count visibility for speakers/… - #303
Closed
rea16068 wants to merge 1 commit into
Closed
[MWPW-205908] Add empty states and fix count visibility for speakers/…#303rea16068 wants to merge 1 commit into
rea16068 wants to merge 1 commit into
Conversation
Collaborator
Author
|
Closing in favor of #306 — opened from a direct branch on adobecom/event-libs now that I have write access, which also allows proper Milestone, Labels, and visual preview via the eventlibs param. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds empty states and fixes count visibility for the speakers and featured-products session-page blocks, per MWPW-205908.
Changes
el.remove()) when there are no products, matching the pattern used byin-person-banner,chrono-box,event-carousel, and others.(N)count in the title once the item count exceeds the visible limit (5 for speakers, 6 for products) — previously the count always rendered even when there was nothing to expand.Resolves: MWPW-205908
Open question for reviewer
Couldn't locate the
:emptyCSS fallback inlibs-styles.cssmentioned as precedent for handling the gridrow-gapwhen the featured-products block is removed from an otherwise-empty.grid-column. Closest related rule is.section.grid(row-gap definition, no:emptyvariant nearby). Flagging for visual verification since I can't preview from a fork branch (eventlibs override only resolves adobecom-owned branches) — please check if an empty grid column leaves a visible gap and whether a fallback is actually needed.Test plan
npx stylelint 'event-libs/v1/c2/blocks/event-*/**/*.css')