[MWPW-205910] Single featured-product tile spans full grid width - #304
Closed
rea16068 wants to merge 1 commit into
Closed
[MWPW-205910] Single featured-product tile spans full grid width#304rea16068 wants to merge 1 commit into
rea16068 wants to merge 1 commit into
Conversation
Collaborator
Author
|
Closing in favor of #305 — opened from a direct branch on adobecom/event-libs now that I have write access, which also allows proper visual preview via the eventlibs param, Milestone, and Labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single CSS rule so a lone featured-product tile spans the full grid width instead of sitting in one half of the 2-column grid.
Change
Targets the direct grid child (
<li class="featured-product">), matching the grid'srepeat(2, 1fr)column structure.Resolves: MWPW-205910
Test plan
npx stylelint 'event-libs/v1/c2/blocks/event-*/**/*.css')grid-columnisn't observable in tests.