[MWPW-205938] Add contextual accessible names for Share, Favorite, an… - #313
Open
rea16068 wants to merge 1 commit into
Open
[MWPW-205938] Add contextual accessible names for Share, Favorite, an…#313rea16068 wants to merge 1 commit into
rea16068 wants to merge 1 commit into
Conversation
…d show-more toggles
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
qiyundai
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MWPW-205938: four session-page controls were missing contextual accessible names per the Stark/Figma annotations, making them indistinguishable to screen-reader users ("Show more", "Show more" repeated with no context).
Changes
Share ${sessionTitle}, falling back to bare "Share" (no trailing space) if no title.Favorite ${sessionTitle}(dropped "this session"), set once at construction — does NOT change when toggled, since aria-pressed already conveys on/off state..sr-onlyspan alongside the existing aria-hidden visible label, so screen readers hear "Show more products" / "Show more speakers" / etc., while the visible text stays "Show more"/"Show less" as designed.Both title-resolving controls use the same logic as the page H1:
getMetadata('title') || getMetadata('en-title')— intentionally NOT theevent-titlemetadata used elsewhere for toast copy.Resolves: MWPW-205938
Built on top of #312 (MWPW-205937)
This PR is based on
MWPW-205937-analytics-taggingrather thandev, since it touches the same four toggle files and needs the explicitdaa-llattributes already in place. The sr-only span's textContent change does NOT affectdaa-ll— verified both are updated independently in each click handler, and existing daa-ll assertions still pass unchanged.Out of scope
event-libs/v1/c2/blocks/sessions-guide/— it already has its own working accessible names.Test plan
npx stylelint 'event-libs/v1/c2/blocks/event-*/**/*.css')Merge note: this PR should be merged (or rebased onto
dev) after #312 merges first.