Skip to content

Conversation

@honstar
Copy link

@honstar honstar commented Nov 7, 2025

Resolves https://jira.corp.adobe.com/browse/MWPW-180759
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

  • added 2 new pages, promotions and promotions-form
  • promotions page to list promotions from odin in /content/dam/mas/promotions is currently hidden in sidenav
  • use https://mwpw-180759--mas--adobecom.aem.live/studio.html#page=promotions&path=acom
  • implemented are only list-view and the creation flow
  • filters and search are not implemented yet
  • transition after creation of a promotion back to list view is also missing atm

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

Test URLs:

- added 2 new pages, promotions and promotions-form
- promotions page to list promotions from odin in /content/dam/mas/promotions is currently hidden in sidenav
- implemented are only list-view and the creation flow
- filters and search are not implemented yet
- transition after creation of a promotion back to list view is also missing atm
@honstar honstar added the do not merge PR should not be merged yet label Nov 7, 2025
@aem-code-sync
Copy link

aem-code-sync bot commented Nov 7, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@honstar honstar requested review from Axelcureno and yesil November 7, 2025 15:27
@honstar honstar marked this pull request as draft November 11, 2025 15:35
@honstar honstar removed the do not merge PR should not be merged yet label Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant