Skip to content

Conversation

@Axelcureno
Copy link
Member

Summary

Refactors top and left navigation with new folder and locale pickers.

Changes

  • Top Nav: Added folder picker and locale picker components with dropdown menus
  • Side Nav: Narrowed from 240px to 75px with icon-based design
  • Side Nav Actions: Added contextual buttons (Save, Create Variation, Duplicate, Publish) for editor mode
  • Locale Support: Added en_CA (Canada English) and renamed fr_CA (Canada French)
  • Styling: Moved inline styles to style.css, updated grid layout and main container

Files Changed

  • New: mas-nav-locale-picker.js, mas-nav-folder-picker.js, mas-side-nav-item.js
  • Modified: mas-top-nav.js, mas-side-nav.js, store.js, constants.js, style.css, swc.js, studio.html

Testing

  • ✅ Folder picker displays all 9 folders
  • ✅ Locale picker displays all locales including new en_CA
  • ✅ Side nav renders with 75px width
  • ✅ Navigation works without editor/variations features
  • ✅ No console errors

@aem-code-sync
Copy link

aem-code-sync bot commented Nov 13, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

Copy link
Collaborator

@npeltier npeltier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm having the country filter twice is weird but i guess it's temporary

@afmicka
Copy link
Collaborator

afmicka commented Nov 14, 2025

@Axelcureno @3ch023 @npeltier

  1. on smaller desktop screens, sidenav does not fit and it has no scroll, therefore the user can not perform the actions that at towards the bottom of the sidenav like deleting the fragment. I have that issue on my MacBook Air 13" and also Nala has the same issue as it loads pages towards the smaller screen sizes and the delete button is not accessible.

Do we know what is the smallest screen resolution we support? I guess MacBook should have to make the cut.. :)

Screenshot 2025-11-14 at 15 10 32
  1. do we want these options NOT to be capitalized? "Ccd" looks awkward to me :)
Screenshot 2025-11-14 at 16 27 14

@afmicka
Copy link
Collaborator

afmicka commented Nov 14, 2025

@Axelcureno I have pushed updates for Nala (renamed folder to surface picker) and added 2 tests for locale and surface change. Anything else we can add separately.

Copy link

@honstar honstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the small folder casing issue, looks very good 👍

@dariiarudenko2023-ops
Copy link

Hi @Axelcureno @3ch023 @npeltier
When testing yesterday, @afmicka and I noticed that there was a difference in which cards are being shown on the ACOM home page between this PR and #432. And today I noticed a change in capitalization in all options in the top nav only with this PR's testing link (see the screenshots below). Any idea why this may be? Have some changes already been pushed?
image
image

@Axelcureno
Copy link
Member Author

Hi @Axelcureno @3ch023 @npeltier When testing yesterday, @afmicka and I noticed that there was a difference in which cards are being shown on the ACOM home page between this PR and #432. And today I noticed a change in capitalization in all options in the top nav only with this PR's testing link (see the screenshots below). Any idea why this may be? Have some changes already been pushed? image image

@dariiarudenko2023-ops yes, folders in uppercase is how it is in Figma. Regarding the content, this might be due to AEM. We should compare against what's in prod.

@afmicka
Copy link
Collaborator

afmicka commented Nov 19, 2025

@Axelcureno locales should not be all capitalized. Locales should be in the form of fr_FR, not FR_FR
Screenshot 2025-11-19 at 10 02 29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants