-
Notifications
You must be signed in to change notification settings - Fork 15
MWPW-183845: Refactor top and left navigation #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
npeltier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm having the country filter twice is weird but i guess it's temporary
|
@Axelcureno I have pushed updates for Nala (renamed folder to surface picker) and added 2 tests for locale and surface change. Anything else we can add separately. |
honstar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the small folder casing issue, looks very good 👍
|
Hi @Axelcureno @3ch023 @npeltier |
@dariiarudenko2023-ops yes, folders in uppercase is how it is in Figma. Regarding the content, this might be due to AEM. We should compare against what's in prod. |
…nable vertical scrolling
|
@Axelcureno locales should not be all capitalized. Locales should be in the form of fr_FR, not FR_FR |







Summary
Refactors top and left navigation with new folder and locale pickers.
Changes
Files Changed
mas-nav-locale-picker.js,mas-nav-folder-picker.js,mas-side-nav-item.jsmas-top-nav.js,mas-side-nav.js,store.js,constants.js,style.css,swc.js,studio.htmlTesting