MWPW-201713: Keep promo code on inline prices when unwrapping mas-field#6339
Open
Axelcureno wants to merge 4 commits into
Open
MWPW-201713: Keep promo code on inline prices when unwrapping mas-field#6339Axelcureno wants to merge 4 commits into
Axelcureno wants to merge 4 commits into
Conversation
Contributor
4 tasks
Member
Author
|
Related MAS PR for the same ticket: adobecom/mas#1076 — matches rich text OSIs when applying promo project codes in the fragment pipeline. |
|
hello @Blainegunn @TsayAdobe @seanchoi0 @joaquinrivero can u pls review this one expeditiously, we are in dire need of it to be merged for BTS promo validation (among other promo validations) thanky ouuuu @3ch023 |
joaquinrivero
requested review from
Blainegunn,
TsayAdobe,
antonio-rmrz and
bozojovicic
July 23, 2026 20:29
Blainegunn
approved these changes
Jul 24, 2026
Blainegunn
left a comment
Blainegunn
left a comment
Contributor
There was a problem hiding this comment.
lgtm, thanks @Axelcureno
Roycethan
approved these changes
Jul 24, 2026
# Conflicts: # libs/blocks/merch-card-autoblock/merch-card-autoblock.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://jira.corp.adobe.com/browse/MWPW-201713
When merch-card-autoblock unwraps a mas-field whose inline content contains a link (marquee price lines with a See terms link), the price spans lose the mas-field ancestor that supplies the promotion code, so they re-resolve at the base price. This stamps data-promotion-code onto each inline price before the unwrap.
Test URLs:
Verified: hero marquee promo line reads US$19.99/mo on Before, US$15.99/mo (with promo code stamped) on After.