Skip to content

Conversation

@adonath
Copy link
Owner

@adonath adonath commented Jul 14, 2025

This PR addresses #10, by removing the dtype check and adding unit tests.

@adonath adonath requested a review from Copilot July 14, 2025 15:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables float64 precision support by removing float32-only checks, updating related casts, expanding test coverage for float64, and adjusting CI to run tests with JAX_ENABLE_X64.

  • Removed dtype enforcement and forced float32 casts in core GMM code
  • Extended tests/test_gmm.py to include expected results for float64
  • Updated GitHub Actions workflow to run tests under both default and float64 modes

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tests/test_gmm.py Added expected values for float64 precision in existing tests
gmmx/gmm.py Commented out float32 checks and removed forced astype calls
.github/workflows/main.yml Changed test steps to use make test and added float64 run
Comments suppressed due to low confidence (2)

.github/workflows/main.yml:47

  • [nitpick] To reduce duplication and simplify CI configuration, consider adding JAX_ENABLE_X64 as a matrix axis instead of separate steps so that tests run in both modes with a single job definition.
        run: make test

tests/test_gmm.py:203

  • The n_iter test does not distinguish between float32 and float64; consider parametrizing expected iteration counts by dtype to explicitly cover both precision modes.
    expected = {"full": [9], "diag": [8, 9, 11]}

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.4%. Comparing base (537cfdd) to head (a8daee3).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            main     #11     +/-   ##
=======================================
+ Coverage   91.7%   92.4%   +0.6%     
=======================================
  Files          4       4             
  Lines        413     410      -3     
  Branches      12      11      -1     
=======================================
  Hits         379     379             
+ Misses        26      24      -2     
+ Partials       8       7      -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adonath adonath merged commit 3218b35 into main Jul 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants