Skip to content

Conversation

@guoyunhe
Copy link

πŸ”— Linked issue

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

#5035

Inspired by Laravel's php artisan lang:publish command. Eject translation template of built-in validation messages to /resources/lang/en/validator.json.

Not sure if this command should be included in core or i18n.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@thetutlage
Copy link
Member

Hello. Thanks for creating the PR. Let's add a couple of tests for this too.

Also, we should not overwrite the existing validator.json file, until the --merge CLI flag is provided. So, by default the command is safe to run, but if there is an existing file it requires explicit opt-in

Copy link
Member

@thetutlage thetutlage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. However, we will need proper tests!

@guoyunhe
Copy link
Author

guoyunhe commented Feb 1, 2026

@thetutlage updated --merge option, exit code, and tests (by Copilot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants