Skip to content

feat: add tsconfig flag to build command #5083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aadamcik wants to merge 1 commit into
base: 7.x
Choose a base branch
from
Open

feat: add tsconfig flag to build command #5083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion commands/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@
})
declare packageManager?: 'npm' | 'pnpm' | 'yarn' | 'yarn@berry' | 'bun'

/**
* Define custom tsconfig path to be used during the build process
*/
@flags.string({ description: 'Define the tsconfig path' })
declare tsconfig?: string

/**
* Log a development dependency is missing
*
Expand Down Expand Up @@ -112,7 +118,9 @@
* Bundle project for production
*/
const stopOnError = this.ignoreTsErrors === true ? false : true
const builtSuccessfully = await bundler.bundle(stopOnError, this.packageManager)
const builtSuccessfully = await bundler.bundle(stopOnError, this.packageManager, {

Check failure on line 121 in commands/build.ts

View workflow job for this annotation

GitHub Actions / typecheck / typecheck (lts/krypton) 

Expected 0-2 arguments, but got 3.

Check failure on line 121 in commands/build.ts

View workflow job for this annotation

GitHub Actions / typecheck / typecheck (latest) 

Expected 0-2 arguments, but got 3.
tsconfigPath: this.tsconfig,
})
if (!builtSuccessfully) {
this.exitCode = 1
}
Expand Down
Loading