fix: return default object if errorsBag is undefined#78
Merged
RomainLanz merged 2 commits intoadonisjs:3.xfrom Jan 29, 2026
Merged
fix: return default object if errorsBag is undefined#78RomainLanz merged 2 commits intoadonisjs:3.xfrom
RomainLanz merged 2 commits intoadonisjs:3.xfrom
Conversation
|
This pull request has been marked as stale because it has been inactive for more than 21 days. Please reopen if you still intend to submit this pull request |
Member
|
Hey @flozdra! 👋🏻 Thanks for the PR! Are you able to add a test to ensure this works as expected? |
Author
|
Hello @RomainLanz! |
Member
|
Perfect! Thanks 🫶 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
None
❓ Type of change
📚 Description
In the following case :
errorsprop from the sessionerrorsBag.errorsBag, so theerrorsprop returned isundefined.errorsprop, causing Inertia'suseFormto still consider there is an error.This PR resolves the issue by always returning an object in the
#resolveValidationErrorsfunction, ensuring theerrorsprop is always merged and up to date client-side.📝 Checklist