Merged
Conversation
Member
|
Looks good. Thanks 👍🏽 Also, automatically falling back to a default amount does make sense, instead of throwing an exception. |
Member
|
Please send a PR for the docs 🙏 |
Contributor
Author
|
thanks, I will do it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#15
❓ Type of change
📚 Description
This PR introduces the ability to pass a custom amount to the increment, consume, and decrement methods of the Limiter.
I'm developing a security/WAF package for AdonisJS. This feature allows for a scoring-based system where different security threats (e.g., path traversal vs. simple 404) can carry different "weights" or penalties.
For the amount parameter, I have currently implemented a fail-safe approach: if a user provides a value <= 0, it defaults to 1.
Should we keep this fail-safe (silent fallback to 1)?
Or should we throw a Exception to alert the developer that they are passing invalid data?
📝 Checklist
I will update the doc if the PR is accepted, no worries