Skip to content

Conversation

@Imunal
Copy link
Contributor

@Imunal Imunal commented Nov 8, 2024

πŸ”— Linked issue

#916

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add missing instanceName option in the MssqlConnectionNode type, which is required to setup if MSSQL is running using instance.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@thetutlage thetutlage merged commit dcec533 into adonisjs:21.x Nov 13, 2024
16 checks passed
@thetutlage
Copy link
Member

Thanks πŸ‘

@Imunal Imunal deleted the add-missing-instanceName-in-mssql branch November 16, 2024 16:42
nadlgit pushed a commit to nadlgit/adonisjs-lucid that referenced this pull request Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants