Remove unnecessary override for strtok3

[ThisIsMissEm]

🔗 Linked issue

This wasn't from an issue, but from an interesting bug found by a discord member. Essentially they had conflicting versions of strtok3 installed, and this caused file uploads via @adonisjs/bodyparser to fail, but seemingly only when it was a .docx file (which sounds like ghosts in the computer tbh).

❓ Type of change

• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This removes the override for strtok3 which was causing in some applications an outdated version of strtok3 to be installed. Lucid doesn't seem to directly depend on strtok3, so I'm guessing this was necessary for something in the broader adonisjs ecosystem, the original commit doesn't give much in the way of details.

The current version of strtok3 that gets installed with adonisjs 6.17.2 is strtok3 10.2.1, but lucid was causing it to be overridden sometimes with strtok3 8.0.1 (I saw this with npm but not with pnpm)

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

Neither are applicable, but I have run the full test suite before and after this change, removing the node_modules folder in between.

[thetutlage]

Thanks 👍

[ThisIsMissEm]

I didn't check other packages for similar, though, which may be worth doing

[thetutlage]

I didn't check other packages for similar, though, which may be worth doing

I think we had it for Lucid, bodyparser and the starter kits. All others have been updated. But still do a quick scan

[ThisIsMissEm]

That looks like all of them: https://github.com/search?q=org%3Aadonisjs+strtok3+&type=code

[thetutlage]

Great. Thanks for hunting it down and fixing it :)