Skip to content

Conversation

@aadamcik
Copy link
Contributor

@aadamcik aadamcik commented Mar 23, 2025

πŸ”— Linked issue

#1098

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Resolves Nullable relations are not extracted correctlyΒ #1098 .
  • This PR fixes the relation extraction when it's nullable or optional.
  • It also adds support to define all relations as optional, so you have better type safety if you want to when checking whether the relation is preloaded.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@aadamcik aadamcik mentioned this pull request Mar 23, 2025
6 tasks
@thetutlage thetutlage merged commit 863f95a into adonisjs:21.x Apr 7, 2025
16 checks passed
@thetutlage
Copy link
Member

Looks good. Thanks πŸ‘

nadlgit pushed a commit to nadlgit/adonisjs-lucid that referenced this pull request Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nullable relations are not extracted correctly

2 participants