Improve logging for failed migrations with --compact-output flag set #1108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barabasbalazs
changed the title
thetutlage
reviewed
May 6, 2025
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
flevi29
reviewed
Jul 23, 2025
| ).length | ||
| const files = Object.values(migrator.migratedFiles) | ||
|
|
||
| const skippedMigrations = files?.filter(({ status }) => status === 'pending').length |
There was a problem hiding this comment.
files is guaranteed to be defined.
- const skippedMigrations = files?.filter(({ status }) => status === 'pending').length
+ const skippedMigrations = files.filter(({ status }) => status === 'pending').length
Member
There was a problem hiding this comment.
Fixed it separately https://github.com/adonisjs/lucid/blob/21.x/commands/migration/_base.ts#L135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1047
❓ Type of change
📚 Description
When the
--compat-outputoption is set to true, the logger will display the failed migration file as per the request in this issue. The other wanted changes suggested in the issue I did not add since running the migrations with--compact-outputwill display the failed sql query and the stacktrace as well.This is what the new compact message will look like:
📝 Checklist