Skip to content

Conversation

@aadamcik
Copy link
Contributor

πŸ”— Linked issue

#1117

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #1117

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@thetutlage
Copy link
Member

Could we have a couple of tests that showcase that defining a relationship as null at type level does work?

@aadamcik aadamcik force-pushed the fix/nullable-relations branch from c7886f8 to 41c47d1 Compare August 30, 2025 12:31
@aadamcik
Copy link
Contributor Author

@thetutlage updated

@aadamcik aadamcik force-pushed the fix/nullable-relations branch from 41c47d1 to e8479f7 Compare August 30, 2025 12:40
@aadamcik aadamcik force-pushed the fix/nullable-relations branch from e8479f7 to 59d1c2e Compare August 31, 2025 09:30
@thetutlage thetutlage merged commit a4e44c9 into adonisjs:21.x Sep 2, 2025
16 checks passed
@thetutlage
Copy link
Member

Thanks. This looks good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ModelQueryBuilderContract.whereHas() cannot be used with optional relation

2 participants