Skip to content

fix(configure): use number schema for SMTP_PORT and update tests#119

Merged
thetutlage merged 1 commit intoadonisjs:10.xfrom
bdwd-dev:fixes/configure
Mar 19, 2026
Merged

fix(configure): use number schema for SMTP_PORT and update tests#119
thetutlage merged 1 commit intoadonisjs:10.xfrom
bdwd-dev:fixes/configure

Conversation

@bdwd-dev
Copy link
Contributor

Ensure SMTP_PORT is validated using Env.schema.number() instead of string. Also updates configure.spec.ts to cover the correct behavior.

🔗 Linked issue

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Fixes #118

Ensure SMTP_PORT is validated as a number instead of a string during configure.

✅ Changes

  • Use Env.schema.number() for SMTP_PORT
  • Keep other env variables as strings
  • Update configure.spec.ts to cover this behavior

🧪 Result

Correct typing for SMTP port and improved test coverage.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Ensure SMTP_PORT is validated using Env.schema.number() instead of string.
Also updates configure.spec.ts to cover the correct behavior.
@thetutlage thetutlage merged commit 6fc1b9c into adonisjs:10.x Mar 19, 2026
2 of 3 checks passed
@thetutlage
Copy link
Member

Thanks 🙏

@bdwd-dev
Copy link
Contributor Author

welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SMTP_PORT is parsed as string instead of number in start/env.ts (mail configuration bug)

2 participants