Skip to content

Make additionalArgs optional #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobbieTheWagner merged 1 commit into from
Sep 22, 2025
Merged

Make additionalArgs optional #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addon/components/drag-sort-item.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ function getComputedStyleInt(element: HTMLElement, cssProp: string) {

interface DragSortItemSignature<Item extends object> {
Args: {
additionalArgs: object;
determineForeignPositionAction: unknown;
additionalArgs?: object;
determineForeignPositionAction?: unknown;
draggingEnabled?: boolean;
dragEndAction?: unknown;
dragStartAction?: (args: {
Expand Down
4 changes: 2 additions & 2 deletions addon/components/drag-sort-list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import type DragSort from 'ember-drag-sort/services/drag-sort';
interface DragSortListSignature<Item extends object> {
Element: HTMLDivElement;
Args: {
additionalArgs: object;
additionalArgs?: object;
childClass?: string;
childTagName?: string;
determineForeignPositionAction?: (args: {
Expand Down Expand Up @@ -136,7 +136,7 @@ export default class DragSortList<Item extends object> extends Component<
const items = this.args.items;
const dragSort = this.dragSort;
const isHorizontal = this.args.isHorizontal;
const targetArgs = this.args.additionalArgs;
const targetArgs = this.args.additionalArgs ?? null;
let targetIndex = 0;

if (isHorizontal) {
Expand Down
4 changes: 2 additions & 2 deletions addon/services/drag-sort.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export default class DragSort<Item extends object> extends Service {
group,
isHorizontal,
}: {
additionalArgs: object;
additionalArgs?: object;
item: Item;
index: number;
items: Array<Item>;
Expand Down Expand Up @@ -132,7 +132,7 @@ export default class DragSort<Item extends object> extends Service {
group?: string;
items: Array<Item>;
isHorizontal?: boolean;
targetArgs: object;
targetArgs: object | null;
targetIndex?: number;
}) {
// Ignore entering irrelevant groups
Expand Down