add support for a new configurable decorator#38
Open
Gaurav0 wants to merge 1 commit intoadopted-ember-addons:mainfrom
Open
add support for a new configurable decorator#38Gaurav0 wants to merge 1 commit intoadopted-ember-addons:mainfrom
Gaurav0 wants to merge 1 commit intoadopted-ember-addons:mainfrom
Conversation
Gaurav0
force-pushed
the
configurable_decorator
branch
from
d979286 to
191b827
Compare
Gaurav0
changed the title
Gaurav0
force-pushed
the
configurable_decorator
branch
from
5cfb4e5 to
c14e54a
Compare
Gaurav0
changed the title
Gaurav0
force-pushed
the
configurable_decorator
branch
from
c14e54a to
ebcb10a
Compare
Gaurav0
changed the title
Gaurav0
force-pushed
the
configurable_decorator
branch
2 times, most recently
from
0a7341c to
5dff2ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #35
It also adds the tests needed.
After discussing with @runspired on Discord, it seems we are stuck shipping a separate new decorator.