Skip to content

Modernize remaining pages and localize shared UI - #1490

Merged
gdams merged 3 commits into
adoptium:mainfrom
gdams:modernize-pages-and-localization
Nov 10, 2026
Merged

gdams merged 3 commits into
adoptium:mainfrom
gdams:modernize-pages-and-localization

Conversation

@gdams

@gdams gdams commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Description of change

Modernize the remaining product, community and reporting pages, and localize shared navigation and calls to action.

  • Refresh business benefits, join, corporate sustainer signup, Temurin overview, nightly builds, supported platforms, events, Slack signup, news listings, download statistics and trends.
  • Tidy Release Notes with compact version cards, localized filters, accessible sorting, readable priority badges, CSV export and responsive table scrolling. Allow selecting all issue types after the default enhancement filter.
  • Translate navigation labels, supporting announcements, the homepage contributor action, business benefits and the refreshed page UI in all seven base locales. Preserve en-GB's English fallback and the original navbar spacing.
  • Remove the statistics tab jump: share the header and navigation in a persistent layout, preserve scroll on tab switches, and reserve chart/control space while trends load.
  • Preserve download links and checksums, event/calendar destinations, news filters and pagination, and the original production HubSpot form IDs and submission callbacks. Hosted HubSpot fields and consent remain unchanged.
  • Remove 18 unreachable component source files, their obsolete tests and styles, and Swiper's dependency, mock and declarations. Keep the active BentoGrid, installation tabs and replacement components. No other dependency versions change.
  • Fix news-card duplicate keys and fixtures, discard AsciiDoc script nodes before rendering, and explicitly assert the expected invalid-download error log in its rejection test.
  • Update existing snapshots and add behavioral coverage for translated links, form integration, filters, stable loading layouts and warning regressions.

Validation

  • npm test — passed: 1,033 tests in 171 files after removing 12 obsolete component test files.
  • npm run build — passed, including TypeScript validation and search-index generation.
  • npx tsc --noEmit — passed.
  • npx eslint 'src/app/[locale]/stats' src/components/Dashboard/Nav — passed.
  • git diff --check — passed.
  • Dependency-lock comparison confirms Swiper is the only removed package and all other package entries are unchanged.
  • Browser checks for the page refresh: responsive layouts at 390, 768 and 1440px; Chinese headings and form panels; French locale-preserving links and news-filter reset; live nightly downloads and Release Notes filtering; original HubSpot iframe rendering without submitting a form.
  • Slow-response statistics-tab check: scroll position and tab position stay unchanged, the shared header stays mounted, and loading/loaded dashboard heights are identical.

Full repository lint was not run. The previously verified news-filter react-hooks/set-state-in-effect error is unchanged from main.

Checklist

  • npm test and npm run build passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

Contributor instructions now reflect the remaining global test mocks. No new logos were added.

Refresh product, community, news and statistics layouts, tidy release notes, and translate navigation and calls to action across supported locales. Preserve forms and downloads, and stabilize statistics tab navigation and loading layouts.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@netlify

netlify Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for adoptium-next ready!

Name Link
🔨 Latest commit 1449b6c
🔍 Latest deploy log https://app.netlify.com/projects/adoptium-next/deploys/6af3885e0a6cc685b7ae8178
😎 Deploy Preview https://deploy-preview-1490--adoptium-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@gdams
gdams requested a review from xavierfacq November 6, 2026 14:58
@codecov

codecov Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.28049% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.84%. Comparing base (04fe86f) to head (1449b6c).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/app/[locale]/stats/trends/trends-client.tsx 83.07% 6 Missing and 16 partials ⚠️
src/components/Dashboard/Nav/index.tsx 33.33% 0 Missing and 6 partials ⚠️
src/components/News/NewsFilters/index.tsx 50.00% 2 Missing and 3 partials ⚠️
src/components/Content/ReleaseNotes/index.tsx 70.00% 0 Missing and 3 partials ⚠️
...omponents/Temurin/NightlyVersionSelector/index.tsx 50.00% 3 Missing ⚠️
src/app/[locale]/news/author/[author]/page.tsx 50.00% 0 Missing and 1 partial ⚠️
...[locale]/news/author/[author]/page/[page]/page.tsx 50.00% 0 Missing and 1 partial ⚠️
[...cale]/temurin/nightly/TemurinNightlyPageClient.tsx](https://app.codecov.io/gh/adoptium/adoptium.net/pull/1490?src=pr&el=tree&filepath=src%2Fapp%2F%5Blocale%5D%2Ftemurin%2Fnightly%2FTemurinNightlyPageClient.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adoptium#diff-c3JjL2FwcC9bbG9jYWxlXS90ZW11cmluL25pZ2h0bHkvVGVtdXJpbk5pZ2h0bHlQYWdlQ2xpZW50LnRzeA==) 75.00% 1 Missing ⚠️
src/components/Events/Timeline/index.tsx 96.00% 1 Missing ⚠️
src/components/NavBar/index.tsx 66.66% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1490      +/-   ##
==========================================
- Coverage   83.13%   82.84%   -0.29%     
==========================================
  Files         208      199       -9     
  Lines        3646     3841     +195     
  Branches     1010     1047      +37     
==========================================
+ Hits         3031     3182     +151     
- Misses        293      314      +21     
- Partials      322      345      +23     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Remove 18 orphaned component source files with obsolete tests, styles, mocks and declarations. Keep active replacement components and remove only Swiper from the dependency graph. Fix news-card keys, discard AsciiDoc script nodes before rendering, and assert the expected invalid-download log in tests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@gdams
gdams enabled auto-merge (squash) November 6, 2026 15:35
@gdams
gdams disabled auto-merge November 10, 2026 20:48
@gdams

gdams commented Nov 10, 2026

Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts on this branch.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@gdams
gdams enabled auto-merge (squash) November 10, 2026 21:11
@chrisguindon
chrisguindon self-requested a review November 10, 2026 22:06
@gdams
gdams merged commit 017aa30 into adoptium:main Nov 10, 2026
12 checks passed
@gdams
gdams deleted the modernize-pages-and-localization branch November 10, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants