Skip to content

Conversation

@Hermann-Core
Copy link
Collaborator

No description provided.

@Hermann-Core Hermann-Core requested review from hugoib and ndefokou June 20, 2025 15:13
@Hermann-Core Hermann-Core linked an issue Jun 20, 2025 that may be closed by this pull request
@Hermann-Core Hermann-Core self-assigned this Jun 20, 2025
@Ogenbertrand
Copy link
Collaborator

Ogenbertrand commented Jun 25, 2025

@hugoib and @ndefokou will check this PR tmm.

Copy link
Collaborator

@ndefokou ndefokou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow All good on my side Mr @Hermann-Core But i think you should resolve the conflicts you are having before we can merge

@Hermann-Core Hermann-Core requested a review from ndefokou June 30, 2025 11:05
@hugoib
Copy link
Collaborator

hugoib commented Jul 3, 2025

The move to a database-backed approach is a significant improvement for scalability, reliability, and deployment flexibility. Great!

Some observations / questions:

  1. Do we need migration logic? (from previous approach to new approach). My take is no since we don't have a lot of deployments but it is worth to ask and confirm.
  2. we no longer need STORAGE_DIRPATH, right?
  3. I wonder if the change of port (3000 / 8080) (why are we changing it?) in the docker-compose is going to break something in our deployment

I reviewed the approach and codebase, now I want to run it locally. I might have issues... asking for support.

Screenshot 2025-07-03 at 10 40 10

Will report back once I can test functionality.

@Hermann-Core
Copy link
Collaborator Author

  1. Do we need migration logic? (from previous approach to new approach). My take is no since we don't have a lot of deployments but it is worth to ask and confirm.
  2. we no longer need STORAGE_DIRPATH, right?
  3. I wonder if the change of port (3000 / 8080) (why are we changing it?) in the docker-compose is going to break something in our deployment

I reviewed the approach and codebase, now I want to run it locally. I might have issues... asking for support.

Screenshot 2025-07-03 at 10 40 10 Will report back once I can test functionality.

Thanks for your comment, I’ll try to address your questions:

  1. We need to update the deployment to eliminate the dependency on the local filesystem. That includes:

    • Ensuring AWS credentials are passed to enable Secrets Manager usage.
    • Removing the STORAGE_DIRPATH environment variable from the deployment configurations, as it's no longer needed.
  2. Yes we don't need it anymore.

  3. The deployment via Helm is independent from the Docker Compose setup. However, the Compose configuration was updated because:

    • The server binds to port 3000 as defined in the Dockerfile.
    • Compose should reflect that, so we can run the app locally without confusion.

For Local Testing

The updated docker-compose.yml now includes all necessary services for running the mediator locally. To get started:

  • Create a .env file in the project root.
  • Copy the content from .env.example, which includes safe defaults.
  • Run:
docker compose up --build

Let me know if you have successfully run it locally

@hugoib
Copy link
Collaborator

hugoib commented Jul 8, 2025

I ran into issues trying to run it, I reached out to Hermann for support.

@Hermann-Core
Copy link
Collaborator Author

Hermann-Core commented Jul 8, 2025

I ran into issues trying to run it, I reached out to Hermann for support.

What issues have you encountered this time please? Did you follow the steps described above before running it locally ?

@hugoib
Copy link
Collaborator

hugoib commented Jul 10, 2025

Approved, I tested the functionality and the did document. I am not up to date with the pipeline of this project and the deployment, I don't know if it will break something or what needs to be adapted in terms of deployment given this change.

If there are no dealbreakers on that side, it can be merged.

@Hermann-Core
Copy link
Collaborator Author

Hi @Awambeng Please could you update the deployment configuration accrording to the first point of my previous comment? Let me know if further information are needed. Checkout also the README.md file to see what is needed.

@Awambeng
Copy link
Collaborator

Hi @Awambeng Please could you update the deployment configuration accrording to the first point of my previous comment? Let me know if further information are needed. Checkout also the README.md file to see what is needed.

Hi @Hermann-Core,
Thanks for the reminder! I’ll check the deployment configuration and the README as suggested. If I need any clarification, I’ll let you know.

Awambeng and others added 2 commits July 11, 2025 15:49
fix: remove STORAGE_DIRPATH from environment variables in deployment and configmap
@Hermann-Core Hermann-Core requested a review from ndefokou July 11, 2025 15:04
@Hermann-Core Hermann-Core merged commit e5e6ca2 into main Jul 11, 2025
2 checks passed
@Hermann-Core Hermann-Core deleted the 399-add-a-centralized-storage-for-the-mediator-did-document branch July 11, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a centralized storage for the mediator DID Document

5 participants