Rewrite scala3-library and scala3-compiler to indent using #17522 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure indentation is correct when removing braces.
If the first indentation of the region is greater than the indentation
of the enclosing region, we use it to indent the whole region.
Otherwise we use the incremented indentation of the enclosing region.
```scala
def foo = {
x // we replicate indentation of x downward in region
y
}
```
```scala
def foo = {
x // indentation of x is incorrect, we increment enclosing indentation
y
}
```
A bigger indentation than the required one is permitted except
just after a closing brace.
```scala
def bar = {
x
.toString // permitted indentation
def foo = {
}
bar // must be unindented, to not fall into the body of foo
}
```
The main reason is that it breaks the non-bootstrapped compilation. Also it is ugly to mix leading operators with back-ticks and without them: ``` x || y `||` : z || u ``` The change can easily be reverted later.
adpi2
changed the title
adpi2
force-pushed
the
insert-indent
branch
9 times, most recently
from
ce73d29 to
de1558d
Compare
adpi2
force-pushed
the
insert-indent
branch
3 times, most recently
from
acbbc94 to
5657b69
Compare
adpi2
force-pushed
the
insert-indent
branch
2 times, most recently
from
0ebb797 to
3549ff2
Compare
adpi2
pushed a commit
that referenced
this pull request
Feb 5, 2025
According to [#1][#1] this is valid syntax: java.lang.@nonnull String [#1]: https://checkerframework.org/jsr308/specification/java-annotation-design.html#qualified-type-syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.