Skip to content

Fix \ for Dual #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 11, 2025
Merged

Fix \ for Dual #236

merged 18 commits into from
Apr 11, 2025

Conversation

ErikQQY
Copy link
Contributor

@ErikQQY ErikQQY commented Mar 25, 2025

Fix: #235

I am not sure what the tests should be or where they should be placed, but the issue with the MWE is resolved with this PR

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 59.18367% with 20 lines in your changes missing coverage. Please review.

Project coverage is 92.43%. Comparing base (dfb4c7c) to head (5bf8c47).

Files with missing lines Patch % Lines
src/overloads/arrays.jl 59.18% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   93.82%   92.43%   -1.40%     
==========================================
  Files          30       30              
  Lines        1183     1230      +47     
==========================================
+ Hits         1110     1137      +27     
- Misses         73       93      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ErikQQY
Copy link
Contributor Author

ErikQQY commented Mar 27, 2025

@adrhill Can we get a patch with this PR? It's kind of blocking SciML/BoundaryValueDiffEq.jl#291

Copy link
Owner

@adrhill adrhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, we're in midst of a paper rebuttal/revision!

@ErikQQY ErikQQY requested a review from adrhill April 4, 2025 09:04
@ErikQQY
Copy link
Contributor Author

ErikQQY commented Apr 4, 2025

Test failures seem not related

@ErikQQY
Copy link
Contributor Author

ErikQQY commented Apr 9, 2025

Bump @adrhill

@ErikQQY ErikQQY requested a review from adrhill April 10, 2025 04:18
This reverts commit 0ff2861.
@adrhill
Copy link
Owner

adrhill commented Apr 11, 2025

Minor revert due to domluna/JuliaFormatter.jl#909.

@adrhill adrhill merged commit e2b86ef into adrhill:main Apr 11, 2025
8 checks passed
@ErikQQY
Copy link
Contributor Author

ErikQQY commented Apr 11, 2025

Awesome!!🚀

@ErikQQY ErikQQY deleted the qqy/ldiv branch April 11, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError with \ using BigFloat
3 participants