-
Notifications
You must be signed in to change notification settings - Fork 911
Navbar Sticky #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Navbar Sticky #33
Conversation
WalkthroughThe Navbar component was updated by adding CSS classes to its root Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/components/Navbar.jsx (1)
11-11: Add a background utility to the sticky nav to prevent “see-through” on scroll
stickykeeps the element in the normal document flow, so as you scroll it may sit above page content while remaining transparent. Unlessnavbaralready guarantees an opaque background, consider adding a Tailwind bg utility (e.g.bg-primaryorbg-[#000]) or a backdrop blur to avoid underlying text/images bleeding through.- <nav className="sticky top-0 w-full flex py-6 justify-between items-center navbar z-50"> + <nav className="sticky top-0 w-full flex py-6 justify-between items-center navbar z-50 bg-primary">Please verify that the existing
.navbarclass sets a non-transparent background; if it does, ignore this suggestion.
Fix the issue add Sticky tag to it
Summary by CodeRabbit