Add ashr sentence#119
Conversation
|
This should be under proprietary and it should be called PASHR to keep with our existing conventions. Also squash your commits. |
aldas
left a comment
aldas
left a comment
There was a problem hiding this comment.
I think it would be useful to add doccomments with possible value meaning from Trimble site https://receiverhelp.trimble.com/oem-gnss/nmea0183-messages-pashr.html for GPS and IMU status. Probably these 2 do not need to be enums as there seems to be different lists of values found from internet.
Kaspermn33
force-pushed
the
add-ashr-message
branch
from
6f25bb8 to
2f79035
Compare
aldas
left a comment
aldas
left a comment
There was a problem hiding this comment.
LGTM.
Just a note: it seems that there are multiple vendor formats for PASHR sentence. In GPSD source current format is found here https://github.com/ntpsec/gpsd/blob/c9b490e32599cc6df56b0adaa24c2fb4fca44783/drivers/driver_nmea0183.c#L3130 currently if this is a problem to someone they can register custom parser for that sentence, which has higher precendence than currently added one.
3 participants
I wasn't sure if this should be under the Normal sentences or the Proprietary sentence type in the README.