Extract & log authentication challenge message#1324
Open
rmilecki wants to merge 1 commit into
Open
Conversation
rmilecki
commented
Nov 26, 2025
rmilecki
commented
rmilecki
force-pushed
the
auth-read-challenge
branch
from
3cc773f to
3fc7d6f
Compare
Collaborator
rmilecki
force-pushed
the
auth-read-challenge
branch
from
3fc7d6f to
4585cf7
Compare
Author
|
@DimitriPapadopoulos: I updated & rebased my branch (and so this pull request). Can you have another look at it, please? |
When gateway replies with a challenge it (usually?) provides a relevant message. Example: ret=6,actionurl=/remote/logincheck,magic=1-12345678,reqid=0,grpid=1,pid=249,is_chal_rsp=1,pass_renew=1,allow_cancel=1,chal_msg=Your password will expire in 3 days. Would you like to change it? Extract such messages and log them so user can understand what went wrong. Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
rmilecki
force-pushed
the
auth-read-challenge
branch
from
4585cf7 to
1027e4c
Compare
DimitriPapadopoulos
approved these changes
Feb 24, 2026
Author
|
Is it good to be merged? |
Author
|
This was approved 2 months ago and no one raised any issues regarding those changes. @DimitriPapadopoulos: can you merge this now, please? |
Author
|
Ping @DimitriPapadopoulos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.