CI: Fix TestPyPI "dev0" versions for master commits on tags#729
Merged
adrienverge merged 1 commit intomasterfrom Mar 23, 2025
Merged
CI: Fix TestPyPI "dev0" versions for master commits on tags#729adrienverge merged 1 commit intomasterfrom
adrienverge merged 1 commit intomasterfrom
Conversation
This fixes a problem in the custom versions `v1.37.0.devN` built for publishing on TestPyPI since commit 325fafa "Publish each master commit with a unique version on TestPyPI". Such versions are constructed by suffixing `.devN`, where `N` is the number of commits since last tags. In the `N = 0` case, we need to add `--long` to `git describe --tags`. Otherwise it yields `v1.37.0` instead of `v1.37.0-0-gbe92e15`, and the CI fails, e.g. on https://github.com/adrienverge/yamllint/actions/runs/14017589005/job/39245225221 packaging.version.InvalidVersion: Invalid version: '1.37.0.devv1.37.0'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem in the custom versions
v1.37.0.devNbuilt for publishing on TestPyPI since commit 325fafa "Publish each master commit with a unique version on TestPyPI".Such versions are constructed by suffixing
.devN, whereNis the number of commits since last tags. In theN = 0case, we need to add--longtogit describe --tags. Otherwise it yieldsv1.37.0instead ofv1.37.0-0-gbe92e15, and the CI fails, e.g. on https://github.com/adrienverge/yamllint/actions/runs/14017589005/job/39245225221