Minor update for forwards compatibility with Honeycomb and fulltext_data_model
#34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: adsingestschema/Document.json modified: adsingestschema/RecordData.json
modified: adsingestschema/Document.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document.Titleto be an array ofTitle.jsonobjects (for upcoming multilingual support)RecordData.jsonto make it more compliant with upcoming db/pipeline architecture$idto Document.json to make it compatible with fulltext_data_modelNote to reviewer: Validation test will fail because the
$idis pointing to the current releasesDocument.jsonURL instead of the one in this update. If you remove the$idfield fromDocument.json, tests will pass as is.