Draft
Conversation
…nt/solr-9.0-no-cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The citation cache takes up ~5GB resident memory per active index in a running Montysolr instance. This doubles during serialization and can cause Solr instances to OOM or go into a GC thrashing state due to a surfeit of small objects created for each query. This code change is what we deploy to our index nodes; as they don't need to serve citation queries, and indexing is already relatively taxing on system memory, removing the citation cache greatly reduces incidence of OOM crashes during the indexing process.
What?
Very inelegantly removes the citation cache. This change as written causes crashes when citation queries are attempted without the cache (which probably shouldn't happen).