Add a MapDB implementation of CitationCache#234
Draft
sstults wants to merge 12 commits intoadsabs:mainfrom
Draft
Add a MapDB implementation of CitationCache#234sstults wants to merge 12 commits intoadsabs:mainfrom
sstults wants to merge 12 commits intoadsabs:mainfrom
Conversation
Remove test code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the limitations of our current in-memory cache is that the whole cache is stored in memory. This was an intentional design decision to prefer query speed over hardware cost. The one of the drawbacks of this approach is that each cache instance is only aware of the Lucene documents in the local index. In order to deploy Montysolr in a multi-shard collection we will need to implement a cache that uses the external document identifiers that are unique across the collection rather than the internal Lucene docids that are only unique to a shard.
This PR is a step in the direction of expanding the number of documents that can be indexed by reducing the memory requirements per-shard.