Test the LRUCache implementation in SolrCloud#236
Open
sstults wants to merge 2 commits intoadsabs:mainfrom
Open
Test the LRUCache implementation in SolrCloud#236sstults wants to merge 2 commits intoadsabs:mainfrom
sstults wants to merge 2 commits intoadsabs:mainfrom
Conversation
JCRPaquin
reviewed
May 27, 2025
Member
JCRPaquin
left a comment
JCRPaquin
left a comment
There was a problem hiding this comment.
One clarifying comment, for my own understanding
| return; | ||
| if (dv.advanceExact(docId)) { | ||
| for (long ord = dv.nextOrd(); ord != SortedSetDocValues.NO_MORE_ORDS; ord = dv.nextOrd()) { | ||
| int count = dv.docValueCount(); |
Member
There was a problem hiding this comment.
Pardon my ignorance here, but what's the difference between iterating over the doc value count and iterating until nextOrd returns NO_MORE_ORDS?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an abstract SolrCloud testing class that tests basic citation graph functionality. To illustrate where and how the citation graph breaks in a multi-shard environment two implementations of that class are included. The single shard class runs without issue. In the second, multi-shard, class the citation consistency check is disabled to avoid introducing failing tests to the build, but it can be re-enabled during development.